Skip to content

Update SQLException to ProgramFailureException#549

Merged
itsankit-google merged 1 commit intodata-integrations:developfrom
cloudsufi:patch/breaking-unit-tests
Jan 28, 2025
Merged

Update SQLException to ProgramFailureException#549
itsankit-google merged 1 commit intodata-integrations:developfrom
cloudsufi:patch/breaking-unit-tests

Conversation

@psainics
Copy link
Contributor

Update SQLException to ProgramFailureException

Breaking due to changes in cdapio/hydrator-plugins#1918

@psainics psainics self-assigned this Jan 28, 2025
@psainics psainics added the build label Jan 28, 2025
@psainics psainics force-pushed the patch/breaking-unit-tests branch from dba4dcc to d472a26 Compare January 28, 2025 02:16
@psainics psainics marked this pull request as ready for review January 28, 2025 06:59
@psainics psainics force-pushed the patch/breaking-unit-tests branch from d472a26 to 69a2af0 Compare January 28, 2025 11:16
Copy link
Contributor

@itsankit-google itsankit-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please check some more details like ErrorReason, ErrorCategory, etc?

The point is we also throw generic ProgramFailureException at multiple places so it would be good to check specifics here.

Copy link
Contributor

@itsankit-google itsankit-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for now, comment can be addressed in a follow up PR.

@itsankit-google itsankit-google merged commit 82ff67a into data-integrations:develop Jan 28, 2025
10 checks passed
@psainics psainics deleted the patch/breaking-unit-tests branch January 28, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants